[NEW] close emoji box using Keyboard Escape key #13956
Conversation
|
|
There was a problem hiding this comment.
@mohamedar97 would you please uncommit package-lock.json and also rebase the code.
|
@knrt10 is this the change you wanted? |
|
This only solves for package-lock.json. See there is one conflicting file. You need to fetch and rebase your local branch and then push again |
|
No problem do this. Make sure this PR is from a fork. If not then
For more info check git documentation on fetch and rebase. |
|
@knrt10 okay i did it, thanks for your patience i'm kinda new to git and still learning |
app/ui-message/client/messageBox.js
Outdated
| @@ -146,6 +146,10 @@ Template.messageBox.onCreated(function() { | |||
| this.isMicrophoneDenied = new ReactiveVar(true); | |||
| this.sendIconDisabled = new ReactiveVar(false); | |||
| messageBox.emit('created', this); | |||
| window.addEventListener('keydown',function(e){ | |||
There was a problem hiding this comment.
I'm not sure this is the best place to do this code. @ggazzo / @tassoevan can you please advise the best place to do this?
@mohamedar97 also this code is not following our code style. please run meteor npm run lint before pushing your changes.
…3956-mohamedar97-issue#13929
ggazzo
changed the title
Closes #13929
added the option to close the emoji box with escape key and added auto focus to emoji search field